fix(sessions): advance Claude parse cursor for filtered transcripts + sanity-check follow-ups#241
Merged
Merged
Conversation
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
ClaudeSource scans every ~/.claude/projects slug and filters rows by recorded cwd, but parse_new returned None when every row was filtered out, so the cursor never advanced for transcripts belonging to other projects (or for appended non-message rows). Every sweep re-read and re-git-probed the entire foreign corpus, O(total transcript bytes x projects) instead of one pass. Returning the empty transcript lets ingest_one persist the advanced cursor without upserting a session, the same contract cline/kiro already use. Also fixes issues surfaced while sanity-checking today's merged PRs: - docs: scrub /home/zack absolute paths from the Hermes parity audit, elide the local analytics project id, and note that the skill-catalog consolidation recommended by SKILL-ADOPTION-RESEARCH.md was implemented by #225 (its skill names describe the old catalog) - agents: point code-health-auditor at tracedecay:code-health (the code-health-report skill was retired in the restructure) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
ScriptedAlchemy
force-pushed
the
fix/merged-pr-sanity-followups
branch
from
ce9fb37 to
46d1295
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from a subagent sanity sweep over today's seven merged PRs (#215, #216, #219, #230, #238, #239, #240).
Confirmed bug (from #239)
ClaudeSource::parse_newreturnedNonewhenever every row of a transcript was filtered out by the per-row cwd check that #239 introduced.ingest_oneonly persists the parse cursor onSome, so the cursor stayed pinned at 0 for every transcript belonging to a different project — and this source deliberately scans every~/.claude/projectsslug. Result: every sweep, in every project, re-read and re-ran per-line git discovery over the entire foreign transcript corpus, forever. Now the empty transcript is returned so the cursor advances;ingest_one's empty-messages branch persists it without upserting a session (the same contract cline/kiro use viaempty_changed_transcript). Regression assertion added toclaude_transcript_for_other_project_is_skipped.Minor cleanups (from #215/#219 review)
/home/zackabsolute paths fromdocs/HERMES-LOOPS-PARITY-AUDIT.mdand elide the local analytics project id indocs/SKILL-ADOPTION-RESEARCH.mdSKILL-ADOPTION-RESEARCH.md: its P1 skill-catalog consolidation was implemented by Improve TraceDecay skill adoption steering #225 the day after the snapshot, so the skill names it lists are the pre-restructure catalogcode-health-auditor.mdreferenced the retiredtracedecay:code-health-reportskill; now points attracedecay:code-healthSanity-sweep verdicts (no action needed)
#216, #219, #230, #238, #240 all came back clean — details in session notes. #238's
make-defaultmold setup was verified against the upstream action source and the mold 2.41.0 release assets (aarch64 included).🤖 Generated with Claude Code